Skip to content

Fix SMSG_TRIGGER_CINEMATIC enum values for 1.12.x#100

Open
Chaosvex wants to merge 3 commits intogtker:mainfrom
Chaosvex:smsg_trigger_cinematic
Open

Fix SMSG_TRIGGER_CINEMATIC enum values for 1.12.x#100
Chaosvex wants to merge 3 commits intogtker:mainfrom
Chaosvex:smsg_trigger_cinematic

Conversation

@Chaosvex
Copy link

@Chaosvex Chaosvex commented Mar 2, 2026

Removed the goblin camera, added Scry_cam and Palantir of Azora. I don't know if the Scry_cam cinematic is actually used as part of a quest but it's a working (short) cinematic sequence.

@gtker
Copy link
Owner

gtker commented Mar 2, 2026

FYI the documentation is auto generated from the wowm files. Run cargo gen (with Rust and Cargo installed) to generate them.

If you don't want to bother learning my DSL and workflows I don't blame you, I'll just run them myself and push them to the PR.

Do you know if the GOBLIN enumerator is just pure fabrication, or did it exist in a previous version?

@Chaosvex
Copy link
Author

Chaosvex commented Mar 2, 2026

I'll generate the docs if you give me a bit of time - I thought the enums were referenced in them.

The Goblin trigger is pure fabrication in 1.12 but may have existed in some broken form in earlier versions. I no longer have my DBC collection from older clients to check, though.

@Chaosvex
Copy link
Author

Chaosvex commented Mar 2, 2026

Checked 0.5 and 1.0. It doesn't exist in either, so I guess it never did. I did wonder since the index is lower and goblins were considered as a playable race early on (IIRC), so it could have been a case of reusing the same index for an old idea... but nope.

Edit: 0.8 also checked, not there, but it does have multiple orc intros - interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants