Skip to content

chore: removing rust-toolchain.toml#2218

Merged
ctron merged 1 commit intoguacsec:mainfrom
helio-frota:drop-rust-toolchain
Jan 28, 2026
Merged

chore: removing rust-toolchain.toml#2218
ctron merged 1 commit intoguacsec:mainfrom
helio-frota:drop-rust-toolchain

Conversation

@helio-frota
Copy link
Contributor

@helio-frota helio-frota commented Jan 27, 2026

Summary by Sourcery

Remove the Rust toolchain configuration file from the repository.

Build:

  • Stop tracking the rust-toolchain.toml file so local toolchain selection is no longer enforced by the repo.

Chores:

  • Clean up obsolete Rust tooling configuration by deleting rust-toolchain.toml.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 27, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR deletes the rust-toolchain.toml file from the repository, removing any repository-pinned Rust toolchain configuration so that Rust version and components are determined by the environment or other tooling instead.

File-Level Changes

Change Details Files
Remove the repository-pinned Rust toolchain configuration file so rustup/cargo no longer use a project-specific toolchain definition.
  • Delete rust-toolchain.toml from the project root
  • Rely on developer or CI default Rust toolchain configuration instead of a checked-in override
rust-toolchain.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@helio-frota helio-frota linked an issue Jan 27, 2026 that may be closed by this pull request
@helio-frota helio-frota requested a review from ctron January 27, 2026 11:15
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.73%. Comparing base (56ee049) to head (91098f2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2218      +/-   ##
==========================================
- Coverage   68.74%   68.73%   -0.01%     
==========================================
  Files         397      397              
  Lines       22322    22322              
  Branches    22322    22322              
==========================================
- Hits        15346    15344       -2     
+ Misses       6070     6068       -2     
- Partials      906      910       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctron
Copy link
Contributor

ctron commented Jan 27, 2026

I think in addition, we should set the minimum supported Rust version. This needs to be done for every project, but can be controlled via the workspace. Like this:

* Also setting minimum supported Rust version aligned with current
rust version available on github action runner.
@helio-frota
Copy link
Contributor Author

Pr updated

@ctron ctron added this pull request to the merge queue Jan 28, 2026
Merged via the queue into guacsec:main with commit a93901a Jan 28, 2026
5 of 6 checks passed
@github-project-automation github-project-automation bot moved this to Done in Trustify Jan 28, 2026
@helio-frota helio-frota deleted the drop-rust-toolchain branch January 28, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Drop rust-toolchain file

2 participants