Add remaining group features #2238
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ctron
commented
Feb 6, 2026
ctron
commented
- chore: ensure groups can't be deleted if they have child groups
- feat: implement SBOM group assignments
- test: ensure the etag changes (or doesn't)
- fix: add an SBOM revision field
- refactor: split off tests into groups
- chore: cleanup tests
- feat: implement SBOM group assignments during upload
- chore: change docs
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Sorry @ctron, your pull request is larger than the review limit of 150000 diff characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2238 +/- ##
==========================================
+ Coverage 69.23% 70.17% +0.94%
==========================================
Files 405 408 +3
Lines 23048 23534 +486
Branches 23048 23534 +486
==========================================
+ Hits 15957 16516 +559
+ Misses 6187 6094 -93
- Partials 904 924 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ctron
force-pushed
the
feature/groups_2
branch
2 times, most recently
from
91ce44c to
ca187fb
Compare
Contributor
Author
|
/scale-test |
|
🛠️ Scale test has started! Follow the progress here: Workflow Run |
Assisted-by: Claude Code
Also, change the data migration to use plain keys. Rather than full models, so that we can migrate the structure of the models. Assisted-By: Claude Code
This required some major refactoring, as there was no way to cover the upload in a transaction. The group assignment, correctly, is part of the fundamental module, so the ingestion can't do it. However, the ingestion can't accept a transaction. Therefore, the ingestion had to be refactored to accept a connection/transaction, like all the other calls. Also, did the "load" methods return an `Id` struct, which could be an internal ID, or one of the digest types. This made it tricky to deal with in a follow up call. As, except for one case, only the internal ID was returned, this was refactored as well. This one case returns a synthetic value anyway.
Also, increase test coverage. Assisted-by: Claude Code
ctron
force-pushed
the
feature/groups_2
branch
from
64ecd14 to
e2728bd
Compare
ctron
force-pushed
the
feature/groups_2
branch
from
1b3c16e to
7f75a46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.