Conversation
|
|
Size Change: +146 kB (+60.91%) 🆘 Total Size: 386 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Noting most changes are:
- File moves and new module structure (modules-v10.11.0 → modules-v10.23.0)
- Typing updates (Event, GuAnalyticsAdapter, UserId)
- Added sendPayload.ts for analytics POSTing
A few questions for for my undertanding/clarity:
- Is sendPayload.ts entirely new behaviour, or refactor for types?
- Should analytics v10 always run, or should it be gated behind the AB test?
- Just confirming pbjs.processQueue() is safe to run immediately on import, even if multiple bundles exist on a page?
the notes added to remove prebid v9 types once the upgrade is proved and the separate upgrade docs for v9 and v10 are super useful 👍
What does this change?
This attempts to reintegrate
prebid v10.23.0alongsideprebid v9.xvia an A/B Test:PrebidJSso the types for prebid v10 have been used in most places, with notes added to remove prebid v9 types once the upgrade is proved successfulWhy?
Upgrading a critical package of ours as well as ensuring we safely transition from one version to the other