Skip to content

Commit 394b813

Browse files
author
sookburt
committed
move interface to more uesful place before deleting otherwise unused file
1 parent c47cdcd commit 394b813

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

dotcom-rendering/src/components/marketing/banners/designableBanner/DesignableBannerV2.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,13 @@ import { addChoiceCardsProductParams } from '../../lib/tracking';
3434
import { ThreeTierChoiceCards } from '../../shared/ThreeTierChoiceCards';
3535
import { bannerWrapper, validatedBannerWrapper } from '../common/BannerWrapper';
3636
import type { BannerRenderProps } from '../common/types';
37-
import type { ChoiceCardSettings } from './components/choiceCards/ChoiceCards';
3837
import { DesignableBannerArticleCount } from './components/DesignableBannerArticleCount';
3938
import { DesignableBannerBody } from './components/DesignableBannerBody';
4039
import { DesignableBannerCloseButton } from './components/DesignableBannerCloseButton';
4140
import { DesignableBannerCtas } from './components/DesignableBannerCtasV2';
4241
import { DesignableBannerHeader } from './components/DesignableBannerHeader';
4342
import { DesignableBannerVisual } from './components/DesignableBannerVisual';
44-
import type { BannerTemplateSettings } from './settings';
43+
import type { BannerTemplateSettings, ChoiceCardSettings } from './settings';
4544
import { templateSpacing } from './styles/templateStyles';
4645

4746
const buildImageSettings = (

dotcom-rendering/src/components/marketing/banners/designableBanner/settings.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import type { TickerSettings } from '@guardian/source-development-kitchen/react-
77
import type { Image } from '@guardian/support-dotcom-components/dist/shared/types';
88
import type { ReactNode } from 'react';
99
import type { BannerId } from '../common/types';
10-
import type { ChoiceCardSettings } from './components/choiceCards/ChoiceCards';
1110

1211
export type ContainerSettings = {
1312
backgroundColour: string;
@@ -38,6 +37,15 @@ export interface HeaderSettings {
3837
headerImage?: Image;
3938
}
4039

40+
export interface ChoiceCardSettings {
41+
buttonColour?: string;
42+
buttonTextColour?: string;
43+
buttonBorderColour?: string;
44+
buttonSelectColour?: string;
45+
buttonSelectTextColour?: string;
46+
buttonSelectBorderColour?: string;
47+
}
48+
4149
export interface BannerTemplateSettings {
4250
containerSettings: ContainerSettings;
4351
primaryCtaSettings: CtaSettings;

0 commit comments

Comments
 (0)