Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
marjisound
force-pushed
the
add-main-media-caption
branch
from
459c645 to
382b79a
Compare
github-actions
bot
removed
the
run_chromatic
JamieB-gu
approved these changes
Jul 23, 2025
Comment on lines
+160
to
+170
| css` | ||
| ${grid.column.centre} | ||
| ${from.leftCol} { | ||
| ${grid.column.left} | ||
| } | ||
| position: relative; | ||
| ${between.tablet.and.leftCol} { | ||
| &::before { | ||
| content: ''; | ||
| position: absolute; | ||
| left: -10px; | ||
| top: 0; | ||
| bottom: 0; | ||
| width: 1px; | ||
| background-color: ${palette( | ||
| '--article-border', | ||
| )}; | ||
| } | ||
| } | ||
| `, | ||
| ]} | ||
| css={[grid.between('centre-column-start', 'grid-end')]} | ||
| > | ||
| Main media caption | ||
| Meta |
Contributor
There was a problem hiding this comment.
Why do we need a placeholder for the meta section? It looks like this section has already been implemented above?
Contributor
Author
There was a problem hiding this comment.
You're right, just removed it 👍
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @marjisound 11 minutes and 8 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds main media caption for Gallery articles
Fixes part of #12648