Add bannerToShow to window.guardian.readerRevenue and log which banner is going to show on the page#14272
Closed
Add bannerToShow to window.guardian.readerRevenue and log which banner is going to show on the page#14272
bannerToShow to window.guardian.readerRevenue and log which banner is going to show on the page#14272Conversation
cemms1
force-pushed
the
cemms1/log-banner-decisions
branch
from
8ddc724 to
07896ea
Compare
cemms1
force-pushed
the
cemms1/log-banner-decisions
branch
from
07896ea to
20686b6
Compare
cemms1
force-pushed
the
cemms1/log-banner-decisions
branch
from
1ffaa3d to
68e6e4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a new property to the
window.guardian.readerRevenuepage,bannerToShow, to indicate which banner should be showing on the pageAdds
supporterRevenuelogging to demonstrate when thepickMessagefunction was run and which banner is going to show on the pageWhy?
Commercial development are implementing an adblock recovery solution and need to prevent it appearing at the same time as supporter revenue banners and the CMP
There is currently no way for the commercial scripts to know whether a supporter revenue banner is intended to show on the page
Screenshots