Loop videos: Reduce size of poster image#14285
Merged
Conversation
domlander
commented
Jul 25, 2025
| image={media.mainMedia.image ?? ''} | ||
| uniqueId={uniqueId} | ||
| atomId={media.mainMedia.atomId} | ||
| posterImage={media.mainMedia.image ?? ''} |
Contributor
Author
There was a problem hiding this comment.
Renamed image to posterImage. This image is only ever used for a poster image.
domlander
commented
Jul 25, 2025
|
|
||
| return generateImageURL({ | ||
| mainImage, | ||
| imageWidth: 940, // The widest a looping video can be: Flexible special, giga-boosted |
Contributor
Author
There was a problem hiding this comment.
This isn't ideal. We'd like to serve a smaller image on smaller screens. Unfortunately, multiple sources are not supported for the poster image of a video.
We could introduce some logic to optimise this, but would require a bit of thought to how it could be maintained if cards/containers change. One for a follow-up PR
domlander
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Fweddi
approved these changes
Jul 25, 2025
|
Seen on PROD (merged by @domlander 8 minutes and 56 seconds ago) Please check your changes! |
domlander
added
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Runs the poster image through the image optimiser to reduce its size
Why?
So that we can serve a lighter page to our users.
Screenshots
The poster image in this example is reduced from 2,114kb to 96kb.