Skip to content

Hide arrow when at end of Scrollable highlights container#14290

Merged
domlander merged 1 commit intomainfrom
doml/scrollable-highlights-bug-fix
Jul 28, 2025
Merged

Hide arrow when at end of Scrollable highlights container#14290
domlander merged 1 commit intomainfrom
doml/scrollable-highlights-bug-fix

Conversation

@domlander
Copy link
Contributor

@domlander domlander commented Jul 28, 2025

What does this change?

Sets the right-margin of the last card in ScrollableHighlights to have zero margin.

Why?

So that the right-arrow doesn't appear when the end of the carousel is reached on desktop.

Screenshots

Before

Screen.Recording.2025-07-28.at.09.05.15.mov

After

Untitled.mov

@domlander domlander self-assigned this Jul 28, 2025
@domlander domlander added run_chromatic Runs chromatic when label is applied and removed dotcom-rendering labels Jul 28, 2025
@domlander domlander marked this pull request as ready for review July 28, 2025 08:08
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jul 28, 2025
@domlander domlander force-pushed the doml/scrollable-highlights-bug-fix branch from 39d07e1 to e8a2dbb Compare July 28, 2025 10:43
@domlander domlander added the run_chromatic Runs chromatic when label is applied label Jul 28, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jul 28, 2025
@domlander domlander changed the title Scrollable highlights bug fix Hide arrow at end of Scrollable highlights container Jul 28, 2025
@domlander domlander changed the title Hide arrow at end of Scrollable highlights container Hide arrow when at end of Scrollable highlights container Jul 28, 2025
Copy link
Contributor

@gnm-notona gnm-notona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@domlander domlander merged commit c279757 into main Jul 28, 2025
31 checks passed
@domlander domlander deleted the doml/scrollable-highlights-bug-fix branch July 28, 2025 11:12
@prout-bot
Copy link

Seen on PROD (merged by @domlander 8 minutes and 59 seconds ago) Please check your changes!

@domlander domlander added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotcom-rendering fronts + curation maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants