Merged
Conversation
The current definition prevents any props being passed to the component.
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the sendReact function to accept a React node instead of a function component, enabling props to be passed to components. The change improves the flexibility of the development server by allowing components to receive props when rendered.
- Modified
sendReactfunction signature to acceptReactNodeinstead ofFunctionComponent - Updated all router files to pass JSX elements instead of component references
- Changed function syntax from arrow function to regular function declaration
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dotcom-rendering/src/devServer/send.tsx | Updated function signature and implementation to accept ReactNode |
| dotcom-rendering/src/devServer/routers/targets.tsx | Updated sendReact calls to pass JSX elements |
| dotcom-rendering/src/devServer/routers/pages.tsx | Updated sendReact calls to pass JSX elements |
| dotcom-rendering/src/devServer/routers/liveApps.tsx | Updated sendReact calls to pass JSX elements |
| dotcom-rendering/src/devServer/routers/editionsApp.tsx | Updated sendReact calls to pass JSX elements |
| dotcom-rendering/src/devServer/routers/dotcom.tsx | Updated sendReact calls to pass JSX elements |
| dotcom-rendering/src/devServer/routers/amp.tsx | Updated sendReact calls to pass JSX elements |
github-actions
bot
removed
the
run_chromatic
arelra
approved these changes
Jul 29, 2025
DanielCliftonGuardian
approved these changes
Jul 29, 2025
|
Seen on PROD (merged by @JamieB-gu 8 minutes and 53 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current definition prevents any props being passed to the component.
Part of #13737.