Skip to content

Update Scrollable Highlights scroll behaviour at large screens#14298

Merged
domlander merged 1 commit intomainfrom
doml/scrollable-highlights-refactor
Aug 4, 2025
Merged

Update Scrollable Highlights scroll behaviour at large screens#14298
domlander merged 1 commit intomainfrom
doml/scrollable-highlights-refactor

Conversation

@domlander
Copy link
Contributor

@domlander domlander commented Jul 29, 2025

What does this change?

  • Updates the scroll padding value on left-col & wide for better alignment.
  • Moves the spacing to align the highlights content with the rest of the page content from the first card to the container.
  • Refactors HighlightsCardImage into its own component.

Why?

  • Refactor ScrollableHighlights before making colour changes in upcoming PR.

Screenshots

Scroll behaviour is now more predictable

Before

Wide

Screen.Recording.2025-07-31.at.10.57.30.mov

Left-col

Screen.Recording.2025-07-31.at.11.01.44.mov

### After

Wide

Screen.Recording.2025-07-31.at.10.59.07.mov

Left-col

Screen.Recording.2025-07-31.at.11.02.49.mov

@domlander domlander self-assigned this Jul 29, 2025
@domlander domlander added run_chromatic Runs chromatic when label is applied fronts + curation labels Jul 29, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jul 29, 2025
@domlander domlander marked this pull request as ready for review July 29, 2025 11:13
@github-actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@domlander domlander changed the title Refactor Scrollable highlights Refactor Scrollable highlights. Update scroll behaviour at large screens Jul 31, 2025
@domlander domlander changed the title Refactor Scrollable highlights. Update scroll behaviour at large screens Update Scrollable Highlights scroll behaviour at large screens Jul 31, 2025
@domlander domlander merged commit 9d74d6f into main Aug 4, 2025
36 checks passed
@domlander domlander deleted the doml/scrollable-highlights-refactor branch August 4, 2025 09:49
@prout-bot
Copy link

Seen on PROD (merged by @domlander 10 minutes and 4 seconds ago) Please check your changes!

@domlander domlander added maintenance Departmental tracking: maintenance work, not a fix or a feature dotcom-rendering and removed dotcom-rendering labels Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotcom-rendering fronts + curation maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants