Add gallery affiliate link disclaimer#14303
Conversation
marjisound
force-pushed
the
add-gallery-affiliate-link-disclaimer
branch
from
3490286 to
1e31a8f
Compare
Using the container we can give it a padding-bottom and also share the grid columns and the left border styling.
marjisound
force-pushed
the
add-gallery-affiliate-link-disclaimer
branch
from
1e31a8f to
57c3c0d
Compare
github-actions
bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
marjisound
force-pushed
the
add-gallery-affiliate-link-disclaimer
branch
from
399a448 to
5424d90
Compare
| rel={ | ||
| isSkimlink(href) | ||
| ? 'sponsored' | ||
| : getAttrs(node)?.getNamedItem('rel')?.value |
There was a problem hiding this comment.
We might want to set this to undefined if not a skimlink?
Or we could check with CP how they expect rel attributes to be propagated on caption links in DCR.
There was a problem hiding this comment.
Oh yes, we had made the change together in the call, but I'd forgotten to push to repo :)
For now lets leave it as undefined (not to impose any change to the existing functionality in prod), but I'll email CP and ask about this
Co-authored-by: Ravi <7014230+arelra@users.noreply.github.com>
Also fix paddings for gallery image and caption
marjisound
force-pushed
the
add-gallery-affiliate-link-disclaimer
branch
from
0994665 to
c9ac19c
Compare
| } | ||
| `; | ||
|
|
||
| const webMetaAndDisclaimerContainer = css` |
There was a problem hiding this comment.
Is this "web" specific? It looks like it wraps both apps and web?
There was a problem hiding this comment.
You have amazing eyes, just fixed it 👍
|
Seen on PROD (merged by @marjisound 18 minutes and 9 seconds ago) Please check your changes! |
4 participants
What does this change?
This PR adds the affiliate links disclaimer to the gallery article only for Web (since I couldn't find the disclaimer on the app version)
The styling is the same as the frontend version, though dark mode styling was added as well. You can find the story in the published storybook here
Relevant frontend PR is: guardian/frontend#28122
This fixes part of #12292