Skip to content

Labs Galleries migration to DCR #14348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 18, 2025
Merged

Labs Galleries migration to DCR #14348

merged 15 commits into from
Aug 18, 2025

Conversation

deedeeh
Copy link
Contributor

@deedeeh deedeeh commented Aug 6, 2025 •
edited by marjisound
Loading

What does this change?

This PR migrates Labs Galleries to DCR. First step to insert ads in Galleries web #14299.

The changes are:

  • Added Labs Header
  • Aligned fonts and color with Frontend PROD.
  • Fixed light and dark mode for Labs Galleries.

The next step to look at is ads in Galleries apps, aka DCAR.

Why?

We want all the Guardian content to be DCAR rendered and this is part of this work.

Screenshots

PROD DEV
before after
before2 after2
before3 after3
before4 after4
before5 after5
before6 after6
before7 after7
before8 after8
before9 after9
before10 after10
before11 after11
before12 after12

This PR fixes #12636

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

Deploy build 44676 of Mobile::mobile-apps-rendering to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

Deploy build 20444 of dotcom:rendering-all to CODE

All deployment options

From guardian/actions-riff-raff.

@deedeeh deedeeh force-pushed the md/labs-galleries-dcr branch from 75987db to cd64d58 Compare August 6, 2025 10:48
@deedeeh deedeeh changed the title Md/labs galleries dcr Labs Galleries migration to DCR Aug 6, 2025
@deedeeh deedeeh force-pushed the md/labs-galleries-dcr branch 2 times, most recently from c561510 to 4849510 Compare August 11, 2025 10:57
deedeeh
deedeeh commented Aug 11, 2025
View reviewed changes
@deedeeh deedeeh force-pushed the md/labs-galleries-dcr branch from 11a283e to d1423c5 Compare August 11, 2025 13:52
deedeeh and others added 11 commits August 11, 2025 16:34
@deedeeh @marjisound
Add Labs header and fix fontStyles for Gallery Labs
c4068b7 
Co-authored-by: Marjan Kalanaki <[email protected]>
@deedeeh @marjisound
Fix stylelint
df31e72
@deedeeh @marjisound
Fix captionTextLight for Labs Gallery
bab468f
@deedeeh @marjisound
Fix caption and standfirst fonts for Labs Gallery
e5d6189 
Co-authored-by: Marjan Kalanaki <[email protected]>
@deedeeh @on-ye @marjisound
Update Contributor font styles for Labs Galleries
fa86c04 
Co-authored-by: Onye Anuna <[email protected]>
@deedeeh @marjisound
Update logo label to be bold
a4cfdde
@deedeeh @marjisound
Add padding-top to gallery image captions
f0ce4ce
@deedeeh @marjisound
Remove duplicate padding-top
ca06088
@deedeeh @marjisound
Update headline and branding styling for Labs Galleries
1448372 
Co-authored-by: Marjan Kalanaki <[email protected]>
@deedeeh @marjisound
Fix styling for end of Labs Galleries links in light mode
dcfd09f
@marjisound @deedeeh
fix the background image colour for sub meta
efd0b62 
Co-authored-by: Dina Hafez <[email protected]>
@marjisound marjisound force-pushed the md/labs-galleries-dcr branch from 4416221 to efd0b62 Compare August 11, 2025 15:34
@deedeeh deedeeh marked this pull request as ready for review August 11, 2025 15:56
@github-actions GitHub Actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@deedeeh deedeeh requested review from a team August 11, 2025 15:57
cemms1
cemms1 reviewed Aug 11, 2025
View reviewed changes
Copy link
Contributor

@cemms1 cemms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really neat! Thank you so much for the detailed PR with all the screenshots ✨

I noticed that the share button hover colours aren't quite right for labs:
Screenshot 2025-08-11 at 17 39 54

Happy to chat through any comments I left

As it's the end of the day I'll re-review tomorrow for the green tick ✅ but it's pretty much there!

@marjisound marjisound linked an issue Aug 12, 2025 that may be closed by this pull request
Labs Galleries #12636
Closed
@deedeeh
Copy link
Contributor Author

deedeeh commented Aug 12, 2025

Looking really neat! Thank you so much for the detailed PR with all the screenshots ✨

I noticed that the share button hover colours aren't quite right for labs: Screenshot 2025-08-11 at 17 39 54

Happy to chat through any comments I left

As it's the end of the day I'll re-review tomorrow for the green tick ✅ but it's pretty much there!

Thank you Charlotte for the great review 🙏🏼

Good spot regarding the hovering colors! I will address your comments and if I have any questions I will leave a comment as a reply.

@deedeeh
Copy link
Contributor Author

deedeeh commented Aug 12, 2025

@cemms1 ok fixed it 👍🏼 I also addressed all comments so let me know if you have any questions.

Screenshot 2025-08-12 at 14 39 56

Jakeii
Jakeii reviewed Aug 18, 2025
View reviewed changes
Jakeii
Jakeii approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@Jakeii Jakeii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ignore my comment as a nitpick :p

dskamiotis
dskamiotis approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@dskamiotis dskamiotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I think there is that Playwright 1 test bug.

@deedeeh
Copy link
Contributor Author

deedeeh commented Aug 18, 2025

This looks good to me, I think there is that Playwright 1 test bug.

Thanks Demetrios. Yes I posted on the WebX channel and waiting for their response.

@deedeeh deedeeh added the run_chromatic Runs chromatic when label is applied label Aug 18, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Aug 18, 2025
@deedeeh deedeeh merged commit 5417fee into main Aug 18, 2025
32 checks passed
@deedeeh deedeeh deleted the md/labs-galleries-dcr branch August 18, 2025 14:19
@gu-prout
Copy link

gu-prout bot commented Aug 18, 2025

Seen on PROD (merged by @deedeeh 14 minutes and 39 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marjisound marjisound marjisound left review comments

@cemms1 cemms1 cemms1 left review comments

@Jakeii Jakeii Jakeii approved these changes

@dskamiotis dskamiotis dskamiotis approved these changes

Assignees
No one assigned
Labels
Commercial 💰 dotcom-rendering Seen-on-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Labs Galleries
5 participants
@deedeeh @Jakeii @marjisound @cemms1 @dskamiotis