Skip to content

Remove temporary body copy colour override on DCAR interactive articles #14361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove temporary body copy colour override on DCAR interactive articles #14361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dotcom-rendering/src/layouts/FullPageInteractiveLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import type { ArticleDeprecated } from '../types/article';
import type { ServerSideTests, Switches } from '../types/config';
import type { FEElement } from '../types/content';
import type { RenderingTarget } from '../types/renderingTarget';
import { temporaryBodyCopyColourOverride } from './InteractiveLayout';
import { interactiveGlobalStyles } from './lib/interactiveLegacyStyling';
import { BannerWrapper, Stuck } from './lib/stickiness';

Expand Down Expand Up @@ -210,7 +209,6 @@ export const FullPageInteractiveLayout = (props: WebProps | AppsProps) => {
<Island priority="critical">
<InteractivesDisableArticleSwipe />
</Island>
<Global styles={temporaryBodyCopyColourOverride} />
</>
)}
{isWeb && (
Expand Down
8 changes: 0 additions & 8 deletions dotcom-rendering/src/layouts/InteractiveLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,13 +201,6 @@ const starWrapper = css`
margin-left: -10px;
`;

export const temporaryBodyCopyColourOverride = css`
.content__main-column--interactive p {
/* stylelint-disable-next-line declaration-no-important */
color: ${themePalette('--article-text')} !important;
}
`;

interface CommonProps {
article: ArticleDeprecated;
format: ArticleFormat;
Expand Down Expand Up @@ -253,7 +246,6 @@ export const InteractiveLayout = (props: WebProps | AppsProps) => {
<Island priority="critical">
<InteractivesDisableArticleSwipe />
</Island>
<Global styles={temporaryBodyCopyColourOverride} />
</>
)}
{article.isLegacyInteractive && (
Expand Down