Skip to content

Bump libs to use beta #14375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Bump libs to use beta #14375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
67c1317
Bump libs to use beta
akinsola-guardian Aug 11, 2025
2be4931
Update bootCmp.ts
akinsola-guardian Aug 13, 2025
b6342e1
Update bootCmp.ts
akinsola-guardian Aug 15, 2025
6faf681
Merge branch 'main' into al-test-geolocation-0825
akinsola-guardian Aug 15, 2025
51412f6
Update affiliate-links.e2e.spec.ts
akinsola-guardian Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotcom-rendering/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@guardian/eslint-config-typescript": "9.0.1",
"@guardian/identity-auth": "6.0.1",
"@guardian/identity-auth-frontend": "8.1.0",
"@guardian/libs": "25.2.0",
"@guardian/libs": "0.0.0-canary-20250811142319",
"@guardian/ophan-tracker-js": "2.3.2",
"@guardian/react-crossword": "6.3.0",
"@guardian/shimport": "1.0.2",
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/playwright/tests/affiliate-links.e2e.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ test.describe('Affiliate links', () => {
const skimlinkLocator = page.locator(skimlinkSelector).first();
const skimlinkRelAttribute =
await skimlinkLocator.getAttribute('rel');
expect(skimlinkRelAttribute).toBe('sponsored');
expect(skimlinkRelAttribute).toContain('sponsored');
});

test('skimlinks should contain the xcust URL parameter', async ({
Expand Down
5 changes: 5 additions & 0 deletions dotcom-rendering/src/client/bootCmp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ const initialiseCmp = async () => {
// If user has the "reject all" benefit then show the reduced, "non-advertised" list
const useNonAdvertisedList = allowRejectAll(isUserSignedIn);

const isInSourcepointGeolocationTest =
window.guardian.config.tests['consentGeolocationTestVariant'] ===
'variant';

const country = code ?? undefined;
cmp.init({
pubData: {
Expand All @@ -76,6 +80,7 @@ const initialiseCmp = async () => {
country,
useNonAdvertisedList,
isUserSignedIn,
isInSourcepointGeolocationTest,
});
log('dotcom', 'CMP initialised');
};
Expand Down
66 changes: 33 additions & 33 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.