Fix the broken headline due to main media bug#14376
Merged
marjisound merged 1 commit intomainfrom Aug 11, 2025
Merged
Conversation
Co-authored-by: Dina Hafez <dina.hafez@guardian.co.uk>
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
deedeeh
approved these changes
Aug 11, 2025
Contributor
deedeeh
left a comment
deedeeh
left a comment
There was a problem hiding this comment.
Looks much better now 👍🏼
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @marjisound 18 minutes and 54 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Dina Hafez dina.hafez@guardian.co.uk
What does this change?
This PR fixes a bug that was introduced in the previous gallery PR #14163
We don't need a
position: relativefor the parent ofLightboxLinkin main media because the button will be invisible for main media in Galleries.Why?
Screenshots