Skip to content

Scrollable highlights design tweaks #14381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 14, 2025
Merged

Scrollable highlights design tweaks #14381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b1f83a8
Hide vertical line from tablet
domlander Aug 12, 2025
7e4f10d
Update card padding on mobile
domlander Aug 12, 2025
880174c
Centralise vertical line
domlander Aug 12, 2025
e181a1e
Reduce the gap between mobile card. Use gap over padding. Adjust spac…
domlander Aug 12, 2025
d590326
Tweak peeking card width
domlander Aug 12, 2025
80387ec
Set height to 100% on very small screens
domlander Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions dotcom-rendering/src/components/Masthead/HighlightsCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,11 @@ const container = css`
display: flex;
flex-direction: column;
justify-content: space-between;
height: 100%;
column-gap: ${space[2]}px;
/** Relative positioning is required to absolutely position the card link overlay */
position: relative;
padding: 10px 10px 0 10px;
padding: ${space[2]}px ${space[2]}px 0 ${space[2]}px;
background-color: ${palette('--highlights-card-background')};

/**
Expand All @@ -55,22 +56,17 @@ const container = css`
${until.mobileMedium} {
min-height: 174px;
}

${between.mobileMedium.and.tablet} {
min-height: 194px;
height: 100%;
}

${from.tablet} {
height: 100%;
width: 160px;
padding: 10px 10px 0 10px;
}

${from.tablet} {
width: 280px;
flex-direction: row;
}

${from.desktop} {
width: 300px;
}
Expand Down Expand Up @@ -105,6 +101,7 @@ const content = css`
padding-bottom: 10px;
}
`;

const starWrapper = css`
width: fit-content;
margin-top: ${space[1]}px;
Expand Down
95 changes: 64 additions & 31 deletions dotcom-rendering/src/components/ScrollableHighlights.importable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { css } from '@emotion/react';
import { from, space, until } from '@guardian/source/foundations';
import { from, space } from '@guardian/source/foundations';
import {
Button,
Hide,
Expand All @@ -19,16 +19,24 @@ type Props = {
};

const containerStyles = css`
padding: ${space[2]}px 0 ${space[3]}px;
${from.tablet} {
padding: 0 ${space[5]}px;
padding: ${space[2]}px ${space[5]}px;
}
${from.wide} {
padding-right: 100px;
}
`;

const cardGap = 10;
const horizontalPaddingMobile = 10;
const horizontalPaddingMobileLandscape = 20;

const carouselStyles = css`
display: grid;
gap: ${cardGap}px;
padding: 0 ${horizontalPaddingMobile}px;
scroll-padding-left: ${horizontalPaddingMobile}px;
grid-auto-columns: 1fr;
grid-auto-flow: column;
overflow-x: auto;
Expand All @@ -37,11 +45,15 @@ const carouselStyles = css`
scroll-behavior: smooth;
overscroll-behavior-x: contain;
overscroll-behavior-y: auto;
${until.tablet} {
scroll-padding-left: 10px;

${from.mobileLandscape} {
padding: 0 ${horizontalPaddingMobileLandscape}px;
scroll-padding-left: ${horizontalPaddingMobileLandscape}px;
}
${from.tablet} {
padding: 0;
scroll-padding-left: 120px;
gap: ${space[5]}px;
}
${from.desktop} {
scroll-padding-left: 240px;
Expand Down Expand Up @@ -70,29 +82,20 @@ const itemStyles = css`
scroll-snap-align: start;
grid-area: span 1;
position: relative;
margin: ${space[2]}px 10px ${space[3]}px;
:first-child {
${from.tablet} {
margin-left: 0;
}
}
:last-child {
${from.tablet} {
margin-right: 0;
}
}
`;

const verticalLineStyles = css`
:not(:last-child)::after {
content: '';
position: absolute;
top: 0;
bottom: 0;
right: -10px;
width: 1px;
background-color: ${palette('--highlights-container-separator')};
transform: translateX(-50%);
${from.tablet} {
:not(:first-child)::before {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ::after to ::before switcheroo seems to align the vertical bar perfectly!

content: '';
position: absolute;
top: 0;
bottom: 0;
left: -10px;
width: 1px;
background-color: ${palette('--highlights-container-separator')};
transform: translateX(-50%);
}
}
`;

Expand Down Expand Up @@ -138,20 +141,50 @@ const nextButtonFadeStyles = css`
* @returns {string} - The CSS styles for the grid layout.
*/
const generateCarouselColumnStyles = (totalCards: number) => {
const peepingCardWidth = space[8];
const peepingCardWidthMobile = 150; // Screens below 375px. Only one card is fully visible;
const peepingCardWidthMobileMedium = space[8];

return css`
${until.mobileMedium} {
grid-template-columns: repeat(${totalCards}, 70%) max(30%);
}

grid-template-columns: repeat(
${totalCards},
max(
180px,
calc(
100vw -
(
${horizontalPaddingMobile +
cardGap +
peepingCardWidthMobile}px
)
)
)
);
${from.mobileMedium} {
grid-template-columns: repeat(
${totalCards},
calc((100% - ${peepingCardWidth}px) / 2)
calc(
(
100vw -
${horizontalPaddingMobile +
2 * cardGap +
peepingCardWidthMobileMedium}px
) / 2
)
);
}
${from.mobileLandscape} {
grid-template-columns: repeat(
${totalCards},
calc(
(
100vw -
${horizontalPaddingMobileLandscape +
2 * cardGap +
peepingCardWidthMobileMedium}px
) / 2
)
);
}

${from.tablet} {
grid-template-columns: repeat(${totalCards}, 1fr);
}
Expand Down