Skip to content

Remove GET endpoints from PROD server #14383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2025
Merged

Remove GET endpoints from PROD server #14383

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0b3812
Remove GET endpoints from PROD server
JamieB-gu Aug 12, 2025
91995a2
Remove unused import
JamieB-gu Aug 12, 2025
e0a711c
Merge branch 'main' into remove-get-endpoints-from-prod-server
arelra Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 0 additions & 62 deletions dotcom-rendering/src/server/server.prod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import {
handleFootballTablesPage,
} from './handler.sportDataPage.web';
import { recordBaselineCloudWatchMetrics } from './lib/aws/metrics-baseline';
import { getContentFromURLMiddleware } from './lib/get-content-from-url';
import { logger } from './lib/logging';
import { requestLoggerMiddleware } from './lib/logging-middleware';
import { recordError } from './lib/logging-store';
Expand Down Expand Up @@ -89,67 +88,6 @@ export const prodServer = (): void => {
app.post('/AppsBlocks', logRenderTime, handleAppsBlocks);
app.post('/EditionsCrossword', logRenderTime, handleEditionsCrossword);

// These GET's are for checking any given URL directly from PROD
app.get(
'/Article/*url',
logRenderTime,
getContentFromURLMiddleware,
handleArticle,
);

app.get(
'/AMPArticle/*url',
logRenderTime,
getContentFromURLMiddleware,
handleAMPArticle,
);

app.get(
'/Front/*url',
logRenderTime,
getContentFromURLMiddleware,
handleFront,
);

app.get(
'/TagPage/*url',
logRenderTime,
getContentFromURLMiddleware,
handleTagPage,
);

app.get(
'/EmailNewsletters',
logRenderTime,
getContentFromURLMiddleware,
handleAllEditorialNewslettersPage,
);

app.get(
'/AppsArticle/*url',
logRenderTime,
getContentFromURLMiddleware,
handleAppsArticle,
);

app.get(
'/AppsInteractive/*url',
logRenderTime,
getContentFromURLMiddleware,
handleAppsInteractive,
);

app.get('/', (req, res) => {
res.send(`
<!DOCTYPE html>
<html>
<body>
<h1>👋</h1>
</body>
</html>
`);
});

// All params to error handlers must be declared for express to identify them as error middleware
// https://expressjs.com/en/api.html#:~:text=Error%2Dhandling%20middleware%20always,see%3A%20Error%20handling
// eslint-disable-next-line @typescript-eslint/no-unused-vars -- all params to error handlers must be declared
Expand Down
Loading