Track card media in data-link-name #14400
Merged
+30
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes tracking the video context somewhat easier
This field indicates what media type the card contains. If there is no media, this is resolved to `none`. We set the link name during card enhancement but we do not know at this stage what the card's media is. This is because we do not know details such as card size, which can impact rendered media. As a result of this, we potentially override the media section of the link name at the card level IF media is displayed on the card.
domlander
reviewed
Aug 14, 2025
domlander
reviewed
Aug 14, 2025
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
domlander
approved these changes
Aug 14, 2025
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @abeddow91 7 minutes and 36 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
CardImageType has been renamed to CardMediaType in this PR for clarity.
Adds the card media type to the link name tracking. This field indicates what media type the card contains. It can be one of the following, which is extended from the CardMediaType.
If there is no media, this is resolved to
none.The link name is set during card enhancement but we do not know at this stage what the card's media is. This is because we do not know details such as card size, which can impact rendered media.
As a result of this, we append the media type to the data link name during rendering.
this results in
dataLinkName: 'news | group-0 | card-@3',turning into
resolvedDataLinkName: 'news | group-0 | card-@3 | media-picture'Why?
Screenshots