Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
arelra
approved these changes
Aug 27, 2025
jamesmockett
commented
Aug 27, 2025
| * instead of Preact | ||
| */ | ||
| resolve: | ||
| build === 'client.web.variant' |
Contributor
Author
There was a problem hiding this comment.
This probably could have been left in place, but I've removed it in case somebody else uses the variant bundle in the meantime and unwittingly enables React.
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @jamesmockett 14 minutes and 29 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Disables building of variant client web bundle
Why?
This was being used to test React on the client (#13736). As this is not currently being actively worked on it makes sense to remove the variant bundle for now as it is being built unnecessarily on CI.