Skip to content

Add onwards upper to galleries #14495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielCliftonGuardian merged 5 commits into from
Sep 16, 2025
Merged

Add onwards upper to galleries #14495

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44b164f
Add onwards upper to galleries
DanielCliftonGuardian Sep 11, 2025
0d8c1cc
Update GalleryLayout.tsx
DanielCliftonGuardian Sep 11, 2025
0bc1728
Merge branch 'main' into gallery-onwards-upper
DanielCliftonGuardian Sep 16, 2025
ccb4788
Update GalleryLayout.tsx
DanielCliftonGuardian Sep 16, 2025
0c649dc
Update GalleryLayout.tsx
DanielCliftonGuardian Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions dotcom-rendering/src/layouts/GalleryLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import { Island } from '../components/Island';
import { LabsHeader } from '../components/LabsHeader';
import { MainMediaGallery } from '../components/MainMediaGallery';
import { Masthead } from '../components/Masthead/Masthead';
import { OnwardsUpper } from '../components/OnwardsUpper.importable';
import { Section } from '../components/Section';
import { Standfirst } from '../components/Standfirst';
import { StickyBottomBanner } from '../components/StickyBottomBanner.importable';
Expand Down Expand Up @@ -406,6 +407,31 @@ export const GalleryLayout = (props: WebProps | AppProps) => {
storyPackage={gallery.storyPackage}
topBorder={showMerchandisingHigh}
/>

<Island priority="feature" defer={{ until: 'visible' }}>
<OnwardsUpper
ajaxUrl={frontendData.config.ajaxUrl}
hasRelated={frontendData.hasRelated}
hasStoryPackage={frontendData.hasStoryPackage}
isAdFreeUser={frontendData.isAdFreeUser}
pageId={frontendData.pageId}
isPaidContent={!!frontendData.config.isPaidContent}
showRelatedContent={frontendData.config.showRelatedContent}
keywordIds={frontendData.config.keywordIds}
contentType={frontendData.contentType}
tags={frontendData.tags}
format={format}
pillar={format.theme}
editionId={frontendData.editionId}
shortUrlId={frontendData.config.shortUrlId}
discussionApiUrl={frontendData.config.discussionApiUrl}
absoluteServerTimes={
switches['absoluteServerTimes'] ?? false
}
renderingTarget={renderingTarget}
/>
</Island>

{/** More Galleries container goes here */}
{showComments && (
<Section
Expand Down
Loading