Skip to content

[auxia] update the determination of mandatoriness#14507

Merged
shtukas merged 2 commits intomainfrom
ph-20250916-1117-definitions
Sep 16, 2025
Merged

[auxia] update the determination of mandatoriness#14507
shtukas merged 2 commits intomainfrom
ph-20250916-1117-definitions

Conversation

@shtukas
Copy link
Contributor

@shtukas shtukas commented Sep 16, 2025

So far we have decided mandatoriness of a gate by whether or not the secondCtaName had a non trivial value or not.

Here we move to using userTreatment.treatmentType, which takes the two values

  • DISMISSABLE_SIGN_IN_GATE
  • NONDISMISSIBLE_SIGN_IN_GATE

This is to be closer to the way Auxia model its data, but also to move towards the release of the gate version 2, which is going to bring two new values for userTreatment.treatmentType

@github-actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Sep 16, 2025
@shtukas shtukas merged commit 9695fe3 into main Sep 16, 2025
28 checks passed
@shtukas shtukas deleted the ph-20250916-1117-definitions branch September 16, 2025 12:46
@gu-prout
Copy link

gu-prout bot commented Sep 16, 2025

Seen on PROD (merged by @shtukas 9 minutes ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants