Merged
Conversation
deedeeh
commented
Sep 29, 2025
deedeeh
commented
Sep 29, 2025
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
cemms1
reviewed
Sep 30, 2025
cemms1
reviewed
Sep 30, 2025
github-actions
bot
removed
the
run_chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR is part of a sequence for Labs container redesign. This particular work uses the new component
SponsoredContentLabel#14549 in the FrontSection to display the badge in the container level in the scenario of 1 brand for all stories.The existing Guardian Labs story already reflects the new change in Storybook so I didn't need to create a new story.
Note: I updated the Labs container header styles to align the bottom of the header with the bottom of the badge and it works perfectly in the scenario of 1 brand for all stories. When I check it for multiple brands, which is still upcoming work, they don't align due to the different
padding-bottomfor the content which is40pxand the header which is36pxwhich is a small difference but still needs to be fixed. We want thepadding-bottomto correspond to different scenarios and container types as some might have differentpadding-bottomcompared to others.Why?
Labs redesign.
Screenshots
Snapshots from CODE for different containers with single badge