Merged
Conversation
The `section` element is meant to be used for a standalone section of a document. This generally is not what this `LeftColumn` component is used to represent. For example, it's most widely used to position a heading within the `Section` component, which typically already includes a `section` itself. `LeftColumn` is for general-purpose, presentational usage, and therefore can't make assumptions about the semantics of the document in which it's used. As a result, a non-semantic element like `div` is a more appropriate choice.
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
jamesmockett
approved these changes
Oct 3, 2025
|
Seen on PROD (merged by @JamieB-gu 7 minutes and 59 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sectionelement is meant to be used for a standalone section of a document1. This generally is not what thisLeftColumncomponent is used to represent. For example, it's most widely used to position a heading within theSectioncomponent, which typically already includes asectionitself.dotcom-rendering/dotcom-rendering/src/components/Section.tsx
Lines 312 to 318 in 1eac64e
LeftColumnis for general-purpose, presentational usage, and therefore can't make assumptions about the semantics of the document in which it's used. As a result, a non-semantic element likediv2 is a more appropriate choice.Footnotes
https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/section ↩
https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/div ↩