Skip to content

Fix ab-testing deploy workflows#14642

Merged
Jakeii merged 5 commits intomainfrom
jlk/fix-ab-testing-deploy-workflows
Oct 8, 2025
Merged

Fix ab-testing deploy workflows#14642
Jakeii merged 5 commits intomainfrom
jlk/fix-ab-testing-deploy-workflows

Conversation

@Jakeii
Copy link
Member

@Jakeii Jakeii commented Oct 8, 2025

What does this change?

Quite a few fixes to get the ab-testing deploy to actually work, not sure how this got past me in #14333 ...

  • The secrets weren't being passed properly to the deploy workflow
  • The calling of the reusable workflow wasn't quite right
  • the build wasn't saved as an artifact to deploy in a later step

Successful deploy after these changes: https://github.com/guardian/dotcom-rendering/actions/runs/18343600883

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

@Jakeii Jakeii force-pushed the jlk/fix-ab-testing-deploy-workflows branch 3 times, most recently from beb71de to 90e3bb2 Compare October 8, 2025 11:39
@Jakeii Jakeii force-pushed the jlk/fix-ab-testing-deploy-workflows branch from 90e3bb2 to f5ed139 Compare October 8, 2025 11:42
@Jakeii Jakeii marked this pull request as ready for review October 8, 2025 11:51
@Jakeii Jakeii requested a review from a team as a code owner October 8, 2025 11:51
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@Jakeii Jakeii added run_chromatic Runs chromatic when label is applied fix labels Oct 8, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 8, 2025
@Jakeii Jakeii requested a review from a team October 8, 2025 11:58
Copy link
Contributor

@GHaberis GHaberis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Jakeii Jakeii merged commit 503dd3c into main Oct 8, 2025
43 checks passed
@Jakeii Jakeii deleted the jlk/fix-ab-testing-deploy-workflows branch October 8, 2025 13:44
@gu-prout
Copy link

gu-prout bot commented Oct 8, 2025

Seen on PROD (merged by @Jakeii 7 minutes and 3 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Departmental tracking: fix Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants