Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
domlander
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
abeddow91
approved these changes
Oct 20, 2025
| aspectRatio={aspectRatio} | ||
| sectionId={sectionId} | ||
| showLabsRedesign={!!showLabsRedesign} | ||
| containerLevel={containerLevel} |
Contributor
There was a problem hiding this comment.
Is it intentional to remove containerLevel?
Contributor
Author
There was a problem hiding this comment.
Yeah it was added in as part of the AB test: https://github.com/guardian/dotcom-rendering/pull/14509/files#diff-6433a32087f12b5255bd7935f7c7a1c1b552f3bd007cbc57799a5c2e49bc9203R324
|
Seen on PROD (merged by @domlander 7 minutes and 54 seconds ago) Please check your changes! |
domlander
added
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes the All Boosts AB test: #14509
PR to remove the experiment: guardian/frontend#28306
Why?
The AB test has concluded and data collected.