Skip to content

Consolidate AB testing workflows #14702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jakeii merged 3 commits into from
Oct 20, 2025
Merged

Consolidate AB testing workflows #14702

Jakeii merged 3 commits into from
Oct 20, 2025

Conversation

@Jakeii
Copy link
Member

@Jakeii Jakeii commented Oct 20, 2025 •
edited
Loading

What does this change?

Don't need separate deploy and CI workflows, the CI workflow should contain the checks and deploy steps but the deploy step will only run on main.

@github-actions
Copy link

github-actions bot commented Oct 20, 2025 •
edited
Loading

Deploy build 58 of dotcom:ab-testing to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions
Copy link

github-actions bot commented Oct 20, 2025 •
edited
Loading

Deploy build 45994 of Mobile::mobile-apps-rendering to CODE

All deployment options

From guardian/actions-riff-raff.

@Jakeii Jakeii force-pushed the jlk/tidy-ab-testing-workflows branch from 0177122 to 1dbe4e8 Compare October 20, 2025 11:48
@Jakeii Jakeii changed the title Consolidate AB testing workflows and update permissions Consolidate AB testing workflows Oct 20, 2025
@github-actions
Copy link

github-actions bot commented Oct 20, 2025 •
edited
Loading

Deploy build 21747 of dotcom:rendering-all to CODE

All deployment options

From guardian/actions-riff-raff.

@Jakeii Jakeii added maintenance run_chromatic Runs chromatic when label is applied labels Oct 20, 2025
@Jakeii Jakeii marked this pull request as ready for review October 20, 2025 11:57
@Jakeii Jakeii requested a review from a team as a code owner October 20, 2025 11:57
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 20, 2025
GHaberis
GHaberis approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@GHaberis GHaberis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@Jakeii Jakeii merged commit d723b3a into main Oct 20, 2025
40 checks passed
@Jakeii Jakeii deleted the jlk/tidy-ab-testing-workflows branch October 20, 2025 12:33
@gu-prout
Copy link

gu-prout bot commented Oct 20, 2025

Seen on PROD (merged by @Jakeii 8 minutes and 26 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GHaberis GHaberis GHaberis approved these changes

Assignees

No one assigned

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jakeii @GHaberis @Reettaphant