Skip to content

Conversation

@Jakeii
Copy link
Member

@Jakeii Jakeii commented Oct 22, 2025

What does this change?

Fix the warning showing in the console, the export wasn't updated in index.ts of ab-testing when changed in #14684 as there was a mysterious @ts-ignore there. Everything works without the ts-ignore so I've removed it, perhaps it was needed in the past?

Why?

Annoying warning, the export is not currently used anywhere, which is why this didn't show up as a linting error. And wouldn't have any implications beyond the warning.

ModuleDependencyWarning: export 'ABTests' (reexported as 'ABTests') was not found in './abTest.ts' (possible exports: activeABtests, allABTests)

@Jakeii Jakeii marked this pull request as ready for review October 22, 2025 09:20
@Jakeii Jakeii added the fix Departmental tracking: fix label Oct 22, 2025
@github-actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@Jakeii Jakeii added the run_chromatic Runs chromatic when label is applied label Oct 22, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 22, 2025
@Jakeii Jakeii merged commit fbcaa75 into main Oct 22, 2025
41 checks passed
@Jakeii Jakeii deleted the jlk/fix-ab-test-error branch October 22, 2025 09:29
emma-imber pushed a commit that referenced this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Departmental tracking: fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants