Skip to content

Conversation

@frederickobrien
Copy link
Contributor

@frederickobrien frederickobrien commented Oct 23, 2025

This adjusts the check for forcing light mode only on interactive articles, adjusting it to only apply on pieces before January 2026. Following the migration to DCAR this felt like a natural, low friction opportunity to further align web and apps.

Signed off by the Interactives crew and good to go.

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

@frederickobrien frederickobrien self-assigned this Oct 23, 2025
@frederickobrien frederickobrien added this to the Visuals milestone Oct 23, 2025
@groakland groakland added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Oct 24, 2025
@frederickobrien frederickobrien force-pushed the dark-mode-for-all-new-web-interactives branch from dc5d364 to 64b02cb Compare October 30, 2025 11:42
@frederickobrien frederickobrien marked this pull request as ready for review October 30, 2025 11:42
@frederickobrien frederickobrien requested a review from a team as a code owner October 30, 2025 11:42
@github-actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@frederickobrien frederickobrien force-pushed the dark-mode-for-all-new-web-interactives branch from 64b02cb to 8218642 Compare October 30, 2025 12:05
hasLiveBlogTopAd: !!frontendData.config.hasLiveBlogTopAd,
hasSurveyAd: !!frontendData.config.hasSurveyAd,
onlyLightColourScheme:
design === ArticleDesign.FullPageInteractive ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick question(s) for my understanding: are full page interactives not currently built with dark mode support? And is that a current limitation of the platform, or is it just not a design consideration at the moment?

Copy link
Contributor Author

@frederickobrien frederickobrien Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SiAdcock. Sorry for the slow reply, there's been a back and forth going on about this. Interactive articles are built to support dark mode but at present only on apps. On the web light mode is currently forced (see #11982). This isn't a limitation of the platform - more to reduce complexity in an already complex dev progress. That said, now the DCAR migration is finished interactive articles are rendered in the same way across web and apps, so why not align dark mode expectations too?

Copy link
Contributor

@SiAdcock SiAdcock Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frederickobrien. Yes, I wonder if aligning light and dark mode support across web and apps might reduce complexity, but I appreciate it's extra work, and dark mode is still in beta, so probably not a priority for teams working on DCAR at the moment.

I've started a doc to track our support of dark mode on the web while it is in beta. Maybe we can add things to it as they come up, so we get a better understanding of the effort it will take to finish this work.

@frederickobrien frederickobrien force-pushed the dark-mode-for-all-new-web-interactives branch 2 times, most recently from edb9fda to ee81a5f Compare November 12, 2025 09:41
@frederickobrien frederickobrien changed the title Make interactives support dark mode across platforms after June 2025 Make interactives support dark mode across platforms after January 2026 Nov 19, 2025
@frederickobrien frederickobrien force-pushed the dark-mode-for-all-new-web-interactives branch from ee81a5f to d0db510 Compare November 19, 2025 11:51
Copy link
Contributor

@jonathonherbert jonathonherbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ronseal, as long as the conversation above does not block :)

@frederickobrien frederickobrien force-pushed the dark-mode-for-all-new-web-interactives branch from d0db510 to 609bb1b Compare December 11, 2025 16:34
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

@frederickobrien frederickobrien force-pushed the dark-mode-for-all-new-web-interactives branch from 3c215c1 to cbdb49f Compare January 9, 2026 11:28
@frederickobrien frederickobrien force-pushed the dark-mode-for-all-new-web-interactives branch from cbdb49f to bf9fe00 Compare January 9, 2026 12:24
@frederickobrien frederickobrien added the run_chromatic Runs chromatic when label is applied label Jan 9, 2026
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jan 9, 2026
@frederickobrien frederickobrien merged commit bc10e88 into main Jan 9, 2026
29 checks passed
@frederickobrien frederickobrien deleted the dark-mode-for-all-new-web-interactives branch January 9, 2026 13:48
@gu-prout gu-prout bot added the Seen-on-PROD label Jan 9, 2026
@gu-prout
Copy link

gu-prout bot commented Jan 9, 2026

Seen on PROD (merged by @frederickobrien 6 minutes and 48 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotcom-rendering maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants