Extend podcast image size in Flexible General half-width slot#14753
Merged
Extend podcast image size in Flexible General half-width slot#14753
Conversation
domlander
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
domlander
force-pushed
the
doml/podcast-sizing-flexgen
branch
from
8362d5a to
24a3b6c
Compare
domlander
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
domlander
force-pushed
the
doml/podcast-sizing-flexgen
branch
from
24a3b6c to
f046d20
Compare
github-actions
bot
removed
the
run_chromatic
domlander
force-pushed
the
doml/podcast-sizing-flexgen
branch
from
f046d20 to
70984f5
Compare
domlander
changed the title
github-actions
bot
removed
the
run_chromatic
domlander
force-pushed
the
doml/podcast-sizing-flexgen
branch
from
70984f5 to
23b9708
Compare
github-actions
bot
removed
the
run_chromatic
domlander
commented
Oct 28, 2025
abeddow91
approved these changes
Oct 28, 2025
github-actions
bot
removed
the
run_chromatic
domlander
force-pushed
the
doml/podcast-sizing-flexgen
branch
from
09c2f0a to
1faf09e
Compare
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
domlander
force-pushed
the
doml/podcast-sizing-flexgen
branch
from
be81d53 to
dd2804a
Compare
domlander
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
domlander
force-pushed
the
doml/podcast-sizing-flexgen
branch
from
dd2804a to
0c7d621
Compare
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
abeddow91
approved these changes
Oct 29, 2025
Contributor
abeddow91
left a comment
abeddow91
left a comment
There was a problem hiding this comment.
I like this solution! thanks for detangling the card sizing, its definitely a confusing
Comment on lines
-179
to
-180
| ${between.tablet.and.desktop} { | ||
| ${fixMediaWidthStyles(mediaFixedSize[tablet])} |
Contributor
There was a problem hiding this comment.
It looks like we no longer account for a size change between tablet and desktop. Is this intentional?
Contributor
Author
There was a problem hiding this comment.
Yep, we didn't make a distinction here: https://github.com/guardian/dotcom-rendering/pull/14753/files#diff-fbf8297916d3e244f5c5288b6fe289a3ac99c9a22d6211ee0d741c6c0c27da8bL593. I've also tested that tablet looks correct.
| isBetaContainer: boolean, | ||
| isSmallCard: boolean, | ||
| ) => { | ||
| if (!isBetaContainer) { |
Contributor
There was a problem hiding this comment.
Nice, this will make it easier to rip out once we fully discontinue old containers
Contributor
Author
There was a problem hiding this comment.
That was my thinking. It should be easy to delete this old code once the time comes.
|
Seen on PROD (merged by @domlander 8 minutes and 55 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Don't fix the podcast image width when the card is horizontal on desktop and the container is not scrollable small.
Simplifies the logic of fixed-size width media including podcasts.
Why?
So that the waveform sticks to the bottom of the card.
Screenshots