Skip to content

Add podcastCover to decideImageWidths - switch (role)#14774

Merged
oliverabrahams merged 3 commits intomainfrom
oa/fix-podcast-image
Oct 31, 2025
Merged

Add podcastCover to decideImageWidths - switch (role)#14774
oliverabrahams merged 3 commits intomainfrom
oa/fix-podcast-image

Conversation

@oliverabrahams
Copy link
Contributor

@oliverabrahams oliverabrahams commented Oct 29, 2025

What does this change?

PodcastCover image role is missing from the else case of the decide Image widths function.

Why?

It will be currently falling back to the default case. It seems like this is not the intention as it exists in format.design === ArticleDesign.LiveBlog || format.design === ArticleDesign.DeadBlog.

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Oct 30, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 30, 2025
@oliverabrahams oliverabrahams marked this pull request as ready for review October 30, 2025 08:58
@github-actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@oliverabrahams oliverabrahams requested a review from a team October 30, 2025 09:19
@oliverabrahams oliverabrahams changed the title Add podcastCover to the picture.tsx default case. Add podcastCover to decideImageWidths - switch (role) Oct 30, 2025
Copy link
Contributor

@JamieB-gu JamieB-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Do you want to remove the default case? That will allow TS to catch non-exhaustive match problems like this in the future.

https://github.com/guardian/typescript-school/blob/main/4-narrowing/slides.md#default-cases

@oliverabrahams
Copy link
Contributor Author

👍

Do you want to remove the default case? That will allow TS to catch non-exhaustive match problems like this in the future.

https://github.com/guardian/typescript-school/blob/main/4-narrowing/slides.md#default-cases

Ohhh nice yea done that now

@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Oct 31, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 31, 2025
@oliverabrahams oliverabrahams merged commit 0e3c2ba into main Oct 31, 2025
31 checks passed
@oliverabrahams oliverabrahams deleted the oa/fix-podcast-image branch October 31, 2025 11:50
@gu-prout
Copy link

gu-prout bot commented Oct 31, 2025

Seen on PROD (merged by @oliverabrahams 7 minutes and 49 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants