Add podcastCover to decideImageWidths - switch (role)#14774
Add podcastCover to decideImageWidths - switch (role)#14774oliverabrahams merged 3 commits intomainfrom
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
JamieB-gu
left a comment
There was a problem hiding this comment.
👍
Do you want to remove the default case? That will allow TS to catch non-exhaustive match problems like this in the future.
https://github.com/guardian/typescript-school/blob/main/4-narrowing/slides.md#default-cases
Ohhh nice yea done that now |
|
Seen on PROD (merged by @oliverabrahams 7 minutes and 49 seconds ago) Please check your changes! |
What does this change?
PodcastCover image role is missing from the
elsecase of the decide Image widths function.Why?
It will be currently falling back to the default case. It seems like this is not the intention as it exists in
format.design === ArticleDesign.LiveBlog || format.design === ArticleDesign.DeadBlog.