Skip to content

Conversation

@marjisound
Copy link
Contributor

@marjisound marjisound commented Dec 1, 2025

What does this change?

This PR adds status to the following data types:

  • FEFootballMatch which is the data provided by frontend for the /FootballMatchSummaryPage route
  • FootballMatch type which is the DCAR type that is parsed from the FEFootballMatch
  • MatchData type that exist within the GetMatchNav component. This is the data that is requested on the client.
  • MatchReportType this type is currently only used in fixtures file. It's an expanded version of the type MatchData
  • Generated new schema for the type changes

TODO:
This PR can be merged after this frontend PR is released guardian/frontend#28435

Fixes #14902

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

@marjisound marjisound force-pushed the add-status-to-match-data branch from 1288b17 to 97373b3 Compare December 3, 2025 14:01
@marjisound marjisound marked this pull request as ready for review December 3, 2025 14:06
@marjisound marjisound requested a review from a team December 3, 2025 14:06
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@marjisound marjisound self-assigned this Dec 3, 2025
@marjisound marjisound added the feature Departmental tracking: work on a new feature label Dec 3, 2025
@marjisound marjisound removed this from the Decommission Legacy App Templates milestone Dec 3, 2025
@marjisound marjisound added the run_chromatic Runs chromatic when label is applied label Dec 8, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 8, 2025
@marjisound marjisound merged commit f85084c into main Dec 10, 2025
32 checks passed
@marjisound marjisound deleted the add-status-to-match-data branch December 10, 2025 09:12
@gu-prout
Copy link

gu-prout bot commented Dec 10, 2025

Seen on PROD (merged by @marjisound 7 minutes and 50 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotcom-rendering feature Departmental tracking: work on a new feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add match state (FT, HT, etc) to header

3 participants