-
Notifications
You must be signed in to change notification settings - Fork 30
Add product carousel #14968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+375
−306
Merged
Add product carousel #14968
Changes from 13 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
48f8df7
Update css on product card to allow for aligning separate cards using…
oliverabrahams 59030e6
Allow the ScrollableCarousel.tsx to define card width by a fraction o…
oliverabrahams a064393
Add scrollable carousel for product cards and story this is for a ful…
oliverabrahams d8ff3e6
fix miss naming of story
oliverabrahams a3497bc
Merge branch 'main' into mob/scrollable-products
oliverabrahams bc1c9bc
Merge branch 'main' into mob/scrollable-products
oliverabrahams a4ce1d7
merge main
oliverabrahams b8a28a0
revert changes to pnpm-lock
oliverabrahams ae0ebf9
rename kind to be `frontCarousel` and `productCarousel`. This makes i…
oliverabrahams f8ffc42
Move the subgrid out of the ScrollableCarousel.tsx and into the Scrol…
oliverabrahams 5e75ea2
fix storybook to add the primaryHeadingText to the fixture
oliverabrahams 59077dd
refactor name of front carousel styles prop
oliverabrahams 8348a10
rename h2Id to headingId
oliverabrahams f03528f
split product carousel into its own component
oliverabrahams 4659f21
make no changes to the ScrollableCarousel.tsx
oliverabrahams 3a4363c
use link element from the DS
oliverabrahams 283e495
remove product carousel component and add it to ScrollableProduct.imp…
oliverabrahams a095d08
Merge branch 'main' into mob/scrollable-products
oliverabrahams 8a119b2
explained which functions are from the scrollableCarousel.
oliverabrahams 8990dfe
Merge branch 'main' into mob/scrollable-products
oliverabrahams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.