Fix self-hosted video width for videos with non-5:4 dimensions #14975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlander
force-pushed
the
doml/fix-video-aspect-ratio-mobile
branch
from
03ae9b9 to
8619f7d
Compare
domlander
added
fronts + curation
maintenance
domlander
force-pushed
the
doml/self-hosted-video-dimensions
branch
2 times, most recently
from
5c7034e to
76713a8
Compare
domlander
force-pushed
the
doml/fix-video-aspect-ratio-mobile
branch
from
8619f7d to
1212d17
Compare
domlander
force-pushed
the
doml/fix-video-aspect-ratio-mobile
branch
from
1212d17 to
7f1b86b
Compare
Contributor
Author
|
Superseded by #15029 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes the non-5:4 video display in the Flexible container slots.
Videos with a width shorter than the width of the slot will fill the width of the slot
Why?
Video should be rendered within a 5:4 slot above the tablet breakpoint. The progress bar should be constrained by the width of the video.
Video should be full-width up until the tablet breakpoint.
Screenshots