More Galleries: fixed card sizes #14981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlander
force-pushed
the
doml/more-galleries-fixed-card-sizes
branch
from
ff73f86 to
55ad5e1
Compare
domlander
added
run_chromatic
domlander
force-pushed
the
doml/more-galleries-fixed-card-sizes
branch
from
21ab3d9 to
4b9c1aa
Compare
github-actions
bot
removed
the
run_chromatic
ioannakok
approved these changes
Dec 12, 2025
Contributor
ioannakok
left a comment
ioannakok
left a comment
There was a problem hiding this comment.
Thanks for the video explainer Dom! Super neat work!
marjisound
approved these changes
Dec 12, 2025
Contributor
marjisound
left a comment
marjisound
left a comment
There was a problem hiding this comment.
Great improvement, thanks for doing it 🥳
|
Seen on PROD (merged by @domlander 8 minutes and 4 seconds ago) Please check your changes! |
JamieB-gu
reviewed
Dec 12, 2025
Comment on lines
+27
to
+31
| parameters: { | ||
| chromatic: { | ||
| viewports: [breakpoints.mobile, breakpoints.desktop], | ||
| }, | ||
| }, |
Contributor
There was a problem hiding this comment.
Just a heads up, the viewports parameter is deprecated1 in favour of the modes API. Here are some docs on our use of modes in DCAR.
Footnotes
Contributor
Author
There was a problem hiding this comment.
Thanks for the heads up! I'll make sure to use modes in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
When there are fewer than 5 onwards content cards, don't allow the cards in the list to expand to fill the space on desktop. No change on mobile.
Why?
Design request.
Reviewer
Please review this commit-by-commit, as I've moved some components/styles around.
Video explainer here: https://drive.google.com/file/d/14HqzDSVaOBu877z59URGcKZFBObMFY65/view
Screenshots