Football match header #15020
Merged
Football match header #15020
+424
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tabs component of the new football match header design. Note that this does not yet include "live" styles.
The new designs for the football match header that will appear across match info pages, liveblogs, and match reports. It makes use of a similar implementation for displaying scores as the previous version, i.e. SVGs, but uses the existing `BigNumber` component. Note that this does not yet include the designs for the live version.
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
DanielCliftonGuardian
approved these changes
Dec 24, 2025
| case 7: | ||
| case 8: | ||
| case 9: | ||
| case 10: |
Contributor
There was a problem hiding this comment.
Suggested change
| case 10: |
If we remove 10 all double digit scores will share the same spacing and alignment logic ?
Contributor
Author
There was a problem hiding this comment.
Good point! Updated.
For the scores, all other 2-digit numbers are created by combining single-digit numbers, so we should also do this for 10. Also updated the spacing between numbers so that a 10 created by combining single-digit numbers looks the same as the 10 SVG.
|
Seen on PROD (merged by @JamieB-gu 9 minutes and 23 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new designs for the football match header (#14901) that will appear across match info pages, liveblogs, and match reports. It makes use of a similar implementation for displaying scores as the previous version, i.e. SVGs, but uses the existing
BigNumbercomponent.Note that this does not yet include the designs for the live version.
Note: This is opened against #14997 for now, until that's merged.
Examples
See Storybook for more examples, and different breakpoints.