Skip to content

Add new dispatch event for when no banner is rendered #15053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dskamiotis wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add new dispatch event for when no banner is rendered #15053

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
772d8ad
Add new dispatch event for when no banner is rendered
dskamiotis Dec 22, 2025
db44cd0
wrap the dispatch event inside a useEffect to prevent test failure in…
dskamiotis Dec 22, 2025
2b37df2
Fix StickyBottomBanner to dispatch 'banner:none' event only when no b…
dskamiotis Dec 22, 2025
73fdc09
Fix premature banner:none event causing mobile sticky race condition …
dskamiotis Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions dotcom-rendering/src/components/StickyBottomBanner.importable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,8 @@ export const StickyBottomBanner = ({
);

const [SelectedBanner, setSelectedBanner] = useState<MaybeFC | null>(null);
const [hasPickMessageCompleted, setHasPickMessageCompleted] =
useState<boolean>(false);
const [asyncArticleCounts, setAsyncArticleCounts] =
useState<Promise<ArticleCounts | undefined>>();

Expand Down Expand Up @@ -365,9 +367,10 @@ export const StickyBottomBanner = ({
};

pickMessage(bannerConfig, renderingTarget)
.then((PickedBanner: () => MaybeFC) =>
setSelectedBanner(PickedBanner),
)
.then((PickedBanner: () => MaybeFC) => {
setSelectedBanner(PickedBanner);
setHasPickMessageCompleted(true);
})
.catch((e) => {
// Report error to Sentry
const msg = `StickyBottomBanner pickMessage - error: ${String(
Expand All @@ -377,6 +380,7 @@ export const StickyBottomBanner = ({
new Error(msg),
'sticky-bottom-banner',
);
setHasPickMessageCompleted(true);
});
}, [
isSignedIn,
Expand All @@ -402,6 +406,15 @@ export const StickyBottomBanner = ({
isInAuxiaControlGroup,
]);

useEffect(() => {
if (hasPickMessageCompleted && SelectedBanner == null) {
document.dispatchEvent(
new CustomEvent('banner:none', {
detail: { readerRevenue: false },
}),
);
}
}, [SelectedBanner, hasPickMessageCompleted]);
if (SelectedBanner) {
return <SelectedBanner />;
}
Expand Down
Loading