Skip to content

Add aria-labels to buttons for WCAG 4.1.2 compliance #15064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielCliftonGuardian merged 3 commits into from
Jan 7, 2026
Merged

Add aria-labels to buttons for WCAG 4.1.2 compliance #15064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7af969d
Add aria-labels to buttons for WCAG 4.1.2 compliance
DanielCliftonGuardian Dec 30, 2025
3826fc7
Pass label as a child of button
DanielCliftonGuardian Jan 5, 2026
530658a
Merge branch 'main' into a11y-aria-labels
DanielCliftonGuardian Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dotcom-rendering/src/components/AudioAtom/AudioAtom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,7 @@ export const AudioAtom = ({
data-testid={isPlaying ? 'pause-button' : 'play-button'}
onClick={() => (isPlaying ? pauseAudio() : playAudio())}
css={buttonStyle}
aria-label={isPlaying ? 'Pause' : 'Play'}
>
{isPlaying ? <PauseSVG /> : <PlaySVG />}
</button>
Expand Down
1 change: 1 addition & 0 deletions dotcom-rendering/src/components/EditionSwitcherBanner.importable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ export const EditionSwitcherBanner = ({ pageId, edition }: Props) => {
type="button"
css={closeButton}
data-link-name="edition-switcher-banner close-banner"
aria-label="Close banner"
onClick={() => {
hideEditionSwitcherBanner();
}}
Expand Down
1 change: 1 addition & 0 deletions dotcom-rendering/src/components/SignInGate/gateDesigns/SignInGateAuxiaV1.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ export const SignInGateAuxiaV1 = ({
data-testid="sign-in-gate-main_dismiss"
data-ignore="global-link-styling"
css={dismissButtonStyles}
aria-label="Dismiss sign-in gate"
onClick={() => {
dismissGate();
trackLink(
Expand Down
2 changes: 2 additions & 0 deletions dotcom-rendering/src/components/SignInGate/gateDesigns/SignInGateAuxiaV2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ export const SignInGateAuxiaV2 = ({
data-testid="sign-in-gate-main_dismiss"
data-ignore="global-link-styling"
css={dismissButtonStyles}
aria-label="Dismiss sign-in gate"
onClick={() => {
dismissGate();
trackLink(
Expand Down Expand Up @@ -189,6 +190,7 @@ export const SignInGateAuxiaV2 = ({
data-testid="sign-in-gate-main_dismiss"
data-ignore="global-link-styling"
css={signInDismissButtonStyles}
aria-label="Dismiss sign-in gate"
onClick={() => {
dismissGate();
trackLink(
Expand Down
6 changes: 5 additions & 1 deletion dotcom-rendering/src/components/marketing/banners/designableBanner/DesignableBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,11 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
'secondary',
)}
hideLabel={true}
/>
>
{isCollapsed
? 'Expand banner'
: 'Collapse banner'}
</Button>
</div>
)}
{!isCollapsableBanner && (
Expand Down
Loading