Skip to content

Conversation

@DanielCliftonGuardian
Copy link
Contributor

@DanielCliftonGuardian DanielCliftonGuardian commented Jan 5, 2026

What does this change?

Fixes WCAG 4.1.2 aria-prohibited-attr violations by ensuring ARIA attributes are only used on elements with roles that permit them.
See https://dequeuniversity.com/rules/axe/4.10/aria-prohibited-attr?application=axeAPI
Part of storybook add on accessibility audit #15058

@DanielCliftonGuardian DanielCliftonGuardian added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Jan 5, 2026
@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Jan 5, 2026
@DanielCliftonGuardian DanielCliftonGuardian added this to the Accessibility milestone Jan 5, 2026
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jan 5, 2026
@DanielCliftonGuardian DanielCliftonGuardian marked this pull request as ready for review January 5, 2026 14:42
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

Copy link
Contributor

@marjisound marjisound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just left a question

@DanielCliftonGuardian DanielCliftonGuardian merged commit b69e6cf into main Jan 7, 2026
28 checks passed
@DanielCliftonGuardian DanielCliftonGuardian deleted the aria-prohibited branch January 7, 2026 10:45
@gu-prout
Copy link

gu-prout bot commented Jan 7, 2026

Seen on PROD (merged by @DanielCliftonGuardian 7 minutes and 38 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants