Skip to content

Update AB testing notification alarm name to easily distinguish between PROD and CODE envs #15089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cemms1 merged 1 commit into from
Jan 6, 2026
Merged

Update AB testing notification alarm name to easily distinguish between PROD and CODE envs #15089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ab-testing/cdk/lib/__snapshots__/notificationLambda.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ exports[`The AB testing notification lambda stack > matches the CODE snapshot 1`
}
],
"AlarmDescription": "Something went wrong notifying test owners of upcoming AB test expiries in ab-testing-notification-lambda-CODE. Please check the logs",
"AlarmName": "AB Testing Notification Failures",
"AlarmName": "ab-testing-notification-lambda-CODE-alarm",
"ComparisonOperator": "GreaterThanThreshold",
"DatapointsToAlarm": 1,
"EvaluationPeriods": 1,
Expand Down Expand Up @@ -941,7 +941,7 @@ exports[`The AB testing notification lambda stack > matches the PROD snapshot 1`
}
],
"AlarmDescription": "Something went wrong notifying test owners of upcoming AB test expiries in ab-testing-notification-lambda-PROD. Please check the logs",
"AlarmName": "AB Testing Notification Failures",
"AlarmName": "ab-testing-notification-lambda-PROD-alarm",
"ComparisonOperator": "GreaterThanThreshold",
"DatapointsToAlarm": 1,
"EvaluationPeriods": 1,
Expand Down
2 changes: 1 addition & 1 deletion ab-testing/cdk/lib/notificationLambda.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export class AbTestingNotificationLambda extends GuStack {
monitoringConfiguration: {
snsTopicName: snsTopic.topicName,
toleratedErrorPercentage: 0,
alarmName: "AB Testing Notification Failures",
alarmName: `${appName}-${props.stage}-alarm`,
alarmDescription: `Something went wrong notifying test owners of upcoming AB test expiries in ${appName}-${props.stage}. Please check the logs`,
lengthOfEvaluationPeriod: Duration.minutes(1),
numberOfEvaluationPeriodsAboveThresholdBeforeAlarm: 1,
Expand Down
Loading