Skip to content

Simplify subheading in the product element. #15099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
oliverabrahams wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Simplify subheading in the product element. #15099

oliverabrahams wants to merge 4 commits into from

Conversation

@oliverabrahams
Copy link
Contributor

@oliverabrahams oliverabrahams commented Jan 7, 2026

What does this change?

  • Uses the Subheading component
  • Moves the use of JSDOM up the chain and into the enhancer.

Why?

  • This uses the same Subheading component as is done elsewhere keeping the subheading logic in one place
  • Fixes a react warning about unique keys in the subheadings in the productElement.
  • Simplifies the logic and dependencies of the components

Screenshots

This looks the same before and after.

@oliverabrahams
simplify subheading in the product element. This also fixes a react w…
4b1f761 
…arning about unique keys in the subheadings in the productElement.
@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Jan 7, 2026
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jan 7, 2026
@oliverabrahams oliverabrahams added maintenance Departmental tracking: maintenance work, not a fix or a feature The Filter labels Jan 7, 2026
@oliverabrahams oliverabrahams self-assigned this Jan 7, 2026
@oliverabrahams oliverabrahams marked this pull request as draft January 7, 2026 16:39
@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Jan 7, 2026
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jan 7, 2026
@github-actions
Copy link

github-actions bot commented Jan 7, 2026 •
edited
Loading

Deploy build 23604 of dotcom:rendering-all to CODE

All deployment options

From guardian/actions-riff-raff.

@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Jan 7, 2026
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oliverabrahams oliverabrahams

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature The Filter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oliverabrahams