Ensure storylinesContent is marked clearly as nullable in tag page schema
#15118
+105
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemms1
commented
Jan 12, 2026
| canonicalUrl?: string; | ||
| contributionsServiceUrl: string; | ||
| storylinesContent?: StorylinesContent; | ||
| // This comment is needed to ensure null is recognised properly in the schema |
Contributor
Author
There was a problem hiding this comment.
This is deliberately not a JSDoc comment to avoid this appearing in the schema itself
cemms1
commented
Jan 12, 2026
| }, | ||
| branding: tagPageBranding, | ||
| canonicalUrl: data.canonicalUrl, | ||
| storylinesContent: data.storylinesContent ?? undefined, |
Contributor
Author
There was a problem hiding this comment.
Use nullish coalescing operator to convert to undefined for rest of DCR to use if null
github-actions
bot
removed
the
run_chromatic
on-ye
approved these changes
Jan 12, 2026
Georges-GNM
approved these changes
Jan 12, 2026
Contributor
|
Thanks, hadn't spotted this as an issue when adding the value 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a nullable type hint comment to the new
storylinesContentfield in the frontend tag page type to ensure the schema treats the field as nullableWhy?
Seems
typescript-json-schemadoesn't recognise nullable types well when translating from types. See YousefED/typescript-json-schema#419Since the addition of
storylinesContent(#15008), I have had problems rendering tag pages locally using DCR due to schema check failuresThis is affecting the Playwright runs in the commercial repo due to it needing to run DCR locally
Screenshots
Example tag page with null
storylinesContent: https://www.theguardian.com/politics/industrial-policy