Fix duplicate keys in DesignableBanner#15134
Merged
jamesmockett merged 1 commit intomainfrom Jan 15, 2026
Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
jamesmockett
force-pushed
the
jm/designable-banner-dup-key
branch
from
04b48c0 to
030c94e
Compare
github-actions
bot
removed
the
run_chromatic
DanielCliftonGuardian
approved these changes
Jan 15, 2026
jamesmockett
force-pushed
the
jm/designable-banner-dup-key
branch
from
030c94e to
c8aabb3
Compare
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @jamesmockett 7 minutes and 8 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Switches to using index rather than image URL for
keywhen iterating over imagesWhy?
In some cases the same image is used at different breakpoints meaning keys may not be unique when iterating through the images in
ResponsiveImage: