Skip to content

Call Fastly API sequentially #15139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jakeii merged 3 commits into from
Jan 15, 2026
+21 −6
Merged

Call Fastly API sequentially #15139

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2a46bc
Call dictionary update commands sequentially
Jakeii Jan 15, 2026
067d8cb
update comment
Jakeii Jan 15, 2026
8b91b02
Merge remote-tracking branch 'origin/main' into jlk/ab-testing/call-f…
Jakeii Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions ab-testing/deploy-lambda/src/lib/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,33 @@ export const fetchAndDeployArtifacts = async (deployments: ArtifactInfo[]) => {
const CONFIG_PREFIX = `${STAGE}/config/ab-testing`;

try {
await Promise.all(
const artifacts = await Promise.all(
deployments.map(async ({ artifact, dictionary }) => {
console.log(
`Fetching artifact /${ARTIFACT_BUCKET_NAME}${CONFIG_PREFIX}/${artifact} from S3 and deploying to Fastly dictionary ${dictionary.name}`,
);
const abTestGroups = await fetchDictionaryArtifact(
ARTIFACT_BUCKET_NAME,
`${CONFIG_PREFIX}/${artifact}`,
);
return await deployDictionary(dictionary, abTestGroups);
return {
dictionary,
keyValues: await fetchDictionaryArtifact(
ARTIFACT_BUCKET_NAME,
`${CONFIG_PREFIX}/${artifact}`,
),
};
}),
);

for (const [i, { dictionary, keyValues }] of artifacts.entries()) {
await deployDictionary(dictionary, keyValues);
console.log(
`Successfully deployed artifact to Fastly dictionary ${dictionary.name}`,
);
if (i !== artifacts.length - 1) {
// Adding a small delay between calls to be sure the updates are not concurrent
// See note in this section of the fastly docs
// https://www.fastly.com/documentation/reference/api/#rate-limiting
await new Promise((resolve) => setTimeout(resolve, 500));
}
}
} catch (error) {
console.error("Error in fetchAndDeployArtifacts:", error);
throw error;
Expand Down
Loading