Skip to content

Re-add data-component to in-body product buttons#15243

Merged
emma-imber merged 2 commits intomainfrom
ei/fix-product-button-tracking
Jan 29, 2026
Merged

Re-add data-component to in-body product buttons#15243
emma-imber merged 2 commits intomainfrom
ei/fix-product-button-tracking

Conversation

@emma-imber
Copy link
Contributor

What does this change?

Adds the data-component back into the in-body product buttons. This was removed last week, but we need it in order to separately track clicks on inline product buttons in articles.

Why?

We noticed on our dashboards that the number of clicks tracked on the product buttons dropped significantly last week.

Screenshots

You can see the component name being added now by inspecting the Ophan request.

Before After
Screenshot 2026-01-29 at 10 54 49 Screenshot 2026-01-29 at 10 54 37

@github-actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@emma-imber emma-imber added the fix Departmental tracking: fix label Jan 29, 2026
@emma-imber emma-imber added the run_chromatic Runs chromatic when label is applied label Jan 29, 2026
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jan 29, 2026
Copy link
Contributor

@charleycampbell charleycampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - excellent spot via the dashboard! Do we need to flag this to A+P?

@emma-imber emma-imber merged commit 783eaac into main Jan 29, 2026
28 of 29 checks passed
@emma-imber emma-imber deleted the ei/fix-product-button-tracking branch January 29, 2026 11:44
@gu-prout
Copy link

gu-prout bot commented Jan 29, 2026

Seen on PROD (merged by @emma-imber 7 minutes and 49 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Departmental tracking: fix Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants