Skip to content

Change epic view tracking threshold back to 0#15267

Merged
tomrf1 merged 2 commits intomainfrom
tf-epic-view
Feb 2, 2026
Merged

Change epic view tracking threshold back to 0#15267
tomrf1 merged 2 commits intomainfrom
tf-epic-view

Conversation

@tomrf1
Copy link
Member

@tomrf1 tomrf1 commented Feb 2, 2026

We use the VIEW event in the datalake for measuring performance of epic variants, for £LTV3/impression.
A previous change set the VIEW event threshold for the epic at 40%.
We've now decided this is not desirable.
This has created the potential for invalid epic tests where a variant has fewer users scrolling to 40%. This can mean the variant has a lower £/INSERT but a higher £/VIEW, incorrectly making it the winner.

This PR changes the threshold back to 0 for the VIEW event.
It also adds a new view tracker, at 40%, for the epic view record in browser storage. This is used for limiting how many epics a user sees per month, and we still want this to be 40%.

Tested in CODE by observing the ophan VIEW event being sent at the top of the epic, and the local storage item (gu.contributions.views) updating part way down it.

@tomrf1 tomrf1 added fix Departmental tracking: fix run_chromatic Runs chromatic when label is applied labels Feb 2, 2026
@tomrf1 tomrf1 marked this pull request as ready for review February 2, 2026 11:18
@tomrf1 tomrf1 requested a review from a team as a code owner February 2, 2026 11:18
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Feb 2, 2026
@tomrf1 tomrf1 merged commit d2cb2b7 into main Feb 2, 2026
31 of 32 checks passed
@tomrf1 tomrf1 deleted the tf-epic-view branch February 2, 2026 12:24
@gu-prout
Copy link

gu-prout bot commented Feb 2, 2026

Seen on PROD (merged by @tomrf1 11 minutes and 48 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Departmental tracking: fix Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants