Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
domlander
force-pushed
the
doml/prefer-mp4-over-hls
branch
from
8a4325d to
da632f5
Compare
domlander
added
run_chromatic
domlander
added
maintenance
abeddow91
approved these changes
Feb 3, 2026
|
Seen on PROD (merged by @domlander 10 minutes and 2 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Prefer MP4 format in self-hosted video over HLS formats.
Why?
iOS doesn't cache m3u8 video segments (.ts) files which is bad for users and CDN costs.
How to test?
In the sources of the video, the MP4 file should be listed above the HLS file.
Check that the MP4 file is downloaded in the network tab instead of the M3U8 files