Stop ignoring images in Chromatic in feature cards#15277
Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
domlander
added
run_chromatic
abeddow91
approved these changes
Feb 2, 2026
Contributor
Author
|
I did a quick Chromatic run to check these changes: https://www.chromatic.com/build?appId=63e251470cfbe61776b0ef19&number=14610 |
|
Seen on PROD (merged by @domlander 6 minutes and 56 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Chromatic will no longer ignore feature cards. This change affects Chromatic only.
On standard cards, the image is separate from the card content: headline, kicker, footer, etc. When there are changes to this content on standard cards, for example, the kicker text changes to blue, Chromatic flags the change. On feature cards, the content is overlaid on top of the image. Since we ignore the area of the page covered by the image, the content is ignored too. There have been instances of accidental changes going out due to Chromatic ignoring the entire card. Not quite blue kickers, but you get the idea.
Images have often led to Chromatic false positives, which is why we have this data-attribute. If following this change we consistently receive false positives, we will reassess.