feat: Convert Google One Tap to a server side test #28160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshCorr
force-pushed
the
ash/google-one-tap
branch
from
4879454 to
e79bef0
Compare
AshCorr
force-pushed
the
ash/google-one-tap
branch
7 times, most recently
from
e1a7c8a to
bf281a6
Compare
AshCorr
force-pushed
the
ash/google-one-tap
branch
from
a41f272 to
e7fe46a
Compare
arelra
approved these changes
Aug 20, 2025
gu-prout
bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @AshCorr 7 minutes and 53 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @AshCorr 8 minutes and 3 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Change the Google One Tap AB test to a Server side experiment, this was suggested in guardian/dotcom-rendering#14335 .
This allows us to not hydrate the GoogleOneTap island at all if a reader is not part of the experiment, which avoids loading unecessary JS on the client side.