Update the comment for the ad free cookie expiry in user-features#3267
Open
Update the comment for the ad free cookie expiry in user-features#3267
Conversation
ensuring the comment points to our current source of truth for user features since we no longer run much client side code in frontend any more
cemms1
force-pushed
the
cemms1/update-ad-free-cookie-comment
branch
from
1423861 to
da46b34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the comment referencing the two day expiry for the ad free cookie in user features
It used to point to the client-side code in
frontendas this is where it was copied from.It now references the
dotcom-renderingcode since this is the code most likely to be running in the browser.Why
We don't use
frontendto render our pages much any more and as such, we rarely run the client-side code.To help future developers understand what the code is doing in various places in the codebase, it is more helpful to direct them to the code that is most likely to be running on users' machines (ie the better source of truth) rather than the reference of where the code originally came from.